terraform-aws-modules / terraform-aws-ecr

Terraform module to create AWS ECR resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/ecr/aws
Apache License 2.0
52 stars 109 forks source link

feat!: Allow multiple scan filters per scan type in registry; Raise MSV of Terraform and AWS provider to 1.0 and 5.0 respectively #29

Closed vrnvikas closed 6 months ago

vrnvikas commented 6 months ago

Description

Increase the functionality of AWS ECR registry scan rules by implementing the capability to accommodate multiple scan filters per scan type, thereby enhancing the flexibility and customization options available for users.

Motivation and Context

This feature became essential during my work on a project where there was a requirement to incorporate multiple filters into the scaling configuration. However, this couldn't be accomplished with the existing implementation.

Breaking Changes

Yes, 'filter' parameter under 'registry_scan_rules,' which has now been renamed to 'filters,' and its data type has been altered from a string to an array of maps. Consequently, users relying on the existing implementation must update their 'registry_scan_rules' configuration to align with these changes in order to effectively utilize the updated features.

How Has This Been Tested?

bryantbiggs commented 6 months ago

@vrnvikas can you also bump the minimum Terraform version to 1.0 and the minimum AWS provider version to 5.0 - This PR will be the major version bump, and then after we can merge #30 as a regular feature (minor version) release

vrnvikas commented 6 months ago

Minimum support versions raised for Terraform and AWS provider to 1.0 and 5.0 respectively.

antonbabenko commented 6 months ago

This PR is included in version 2.0.0 :tada:

github-actions[bot] commented 5 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.