search

terraform-aws-modules / terraform-aws-ecr

Terraform module to create AWS ECR resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/ecr/aws
Apache License 2.0
52 stars 109 forks source link

Public ECR Resource is missing TAG attribute #39

Closed MikeySoftNL closed 5 months ago

MikeySoftNL commented 5 months ago

Description

When creating a public repository it is not supplied the var.tags variable value

Versions

Reproduction Code [Required]

module "ecr_public" { source = "terraform-aws-modules/ecr/aws"

repository_name = "my-ecr" repository_type = "public"

tags = { Name = "my-ecr" } }

Expected behavior

Terraform Plan SHOULD show

resource "aws_ecrpublic_repository" "this" { .... tags = { Name = "my-ecr" } .... }

Actual behavior

resource "aws_ecrpublic_repository" "this" { .... tags = {} .... }

Solution

in main.tf on line 240 add

tags = var.tags

antonbabenko commented 5 months ago

This issue has been resolved in version 2.2.1 :tada:

github-actions[bot] commented 4 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.