feat: Add a new variable to control the creation of a lifecycle policy

phr3nzii commented 2 years ago

Description

This pull request adds a new variable that determines whether a lifecycle policy is created. The previous default behaviour was to always create a lifecycle policy. If you didn't want a lifecycle policy, there was no way to do this. You will now have to set create_lifecycle_policy to true if you want a lifecycle policy to be created.
Add missing usage of create_repository_policy variable to policy creation

Motivation and Context

Sometimes a lifecycle policy isn't needed or wanted. This fixes https://github.com/terraform-aws-modules/terraform-aws-ecr/issues/2 Closes #5

Breaking Changes

I wouldn't call this a breaking change. However, users who do want to have a lifecycle policy created will need to add the new variable to ensure that it is created.

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

I have tested using the complete example by setting create_lifecycle_policy to both true and false. I've also updated this example to ensure that the lifecycle policy is created in future.

I also tested this using the reproduction code from https://github.com/terraform-aws-modules/terraform-aws-ecr/issues/2

antonbabenko commented 2 years ago

This PR is included in version 1.3.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-ecr