terraform-aws-modules / terraform-aws-ecs

Terraform module to create AWS ECS resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/ecs/aws
Apache License 2.0
575 stars 542 forks source link

Why set `create_cloudwatch_log_group = false enable_cloudwatch_logging = false ` but it still create new log group? #209

Closed dungle-rg closed 2 months ago

dungle-rg commented 4 months ago

Hi guys! When I create my service with :

 create_cloudwatch_log_group = false
  enable_cloudwatch_logging   = false
  cloudwatch_log_group_name = aws_cloudwatch_log_group.this.name

I have seen that it still create new log group for service and i do not want as this.

richardgavel-ordinaryexperts commented 4 months ago

Are you sure the terraform module created it? ECS will auto create log groups if they are referenced but do not exist. Does a module.xxx.aws_cloudwatch_log_group.this resource appear in the state file? I assume your point is to have cloudwatch logging, but to a pre-existing log group? Do you also pass in your own logging_configuration?

dungle-rg commented 4 months ago

@richardgavel-ordinaryexperts I'm sure module created it!

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 2 months ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 1 month ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.