terraform-aws-modules / terraform-aws-ecs

Terraform module to create AWS ECS resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/ecs/aws
Apache License 2.0
575 stars 542 forks source link

feat: Add support for restartPolicy #231

Closed psantus closed 2 months ago

psantus commented 2 months ago

Description

ECS now supports the ability to restart containers when they crash.

Supporting documentation:

Motivation and Context

Fixes #230

Breaking Changes

Shouldn't be breaking as older terraform provider versions will just ignore restartPolicy and a default value is provided with enabled = false (default behaviour when it's absent)

How Has This Been Tested?

psantus commented 2 months ago

Test screnshot

psantus commented 2 months ago

It now works fine (fixed the validation test on var.restart_policy)

psantus commented 2 months ago

@bryantbiggs is the "Optional object type attributes are experimental" fail a problem? I believe it's long been in Terraform core (since 1.3)

bryantbiggs commented 2 months ago

it was introduced in Terraform 1.3, but on main we only support Terraform 1.0 and hence the failure (edit - on main we provide support up to a MSV of 1.0)

psantus commented 2 months ago

Cheers @bryantbiggs. Do you have an ETA for v6?

RRosalia commented 2 months ago

This is amazing! When will a new tag release be done? So we can start using it?

github-actions[bot] commented 1 month ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.