fix: Update supported throughput_mode in readme

terraform-aws-modules / terraform-aws-efs

Terraform module to create AWS EFS resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/efs/aws

Apache License 2.0

24 stars 38 forks source link

fix: Update supported throughput_mode in readme #12

Closed cheadman closed 1 year ago

cheadman commented 1 year ago

Description

The readme only had "bursting" and "provisioned" as supported throughput_mode values, incorrectly suggesting that the aws recommended value of "elastic" is not supported

Motivation and Context

when people read to see what values are supported they would be misinformed.

Breaking Changes

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

cheadman commented 1 year ago

I did not update line 35 of https://github.com/terraform-aws-modules/terraform-aws-efs/blob/master/examples/complete/main.tf but it really is not needed.

While this issue is already closed, my pull request addresses some of the confusion beyond the creation of the issue.

bryantbiggs commented 1 year ago

this would need to be updated in the variable description and then you can run pre-commit run -a to update the docs accordingly

github-actions[bot] commented 1 year ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] commented 1 year ago

This PR was automatically closed because of stale in 10 days

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.