fix: Allow passing up to the maximum of 2 lifecycle policy statements

kartsm commented 1 year ago

Description

Motivation and Context

Resolves #2

Breaking Changes

Does not break backwards compatibility.

How Has This Been Tested?

[X] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[-] I have tested and validated these changes using one or more of the provided examples/* projects

I do not have access to an AWS account where I can easily deploy a VPC without organizational repercussions. So I did what I could

To test, I started with this code, which referenced a local clone of my fork:
```
module "maybe_efs" {
source = "../../../terraform-aws-efs"
create = true
name = "lorem-ipsum"
lifecycle_policy = {
transition_to_ia = "AFTER_7_DAYS"
transition_to_primary_storage_class = "AFTER_1_ACCESS"
}
}
```
Plan and apply, successful with both attributes
Comment out transition_to_ia
Plan and apply, successful with only transition_to_primary_storage_class
Comment out transition_to_primary_storage_class
Plan and apply, successful with no attributes
Uncomment transition_to_ia
Plan and apply, successful with only transition_to_ia
Uncomment transition_to_primary_storage_class
Plan and apply, successful with both attributes
Plan and destroy, successful
[X] I have executed pre-commit run -a on my pull request

bryantbiggs commented 1 year ago

@kartsm I don't have permission to update your branch so I've opened a PR to update your branch https://github.com/KAR-AUTO/terraform-aws-efs/pull/1

antonbabenko commented 1 year ago

This PR is included in version 1.1.1 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-efs