feat: Allow users to opt out of `NonSecureTransport` policy requirement

terraform-aws-modules / terraform-aws-efs

Terraform module to create AWS EFS resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/efs/aws

Apache License 2.0

24 stars 38 forks source link

feat: Allow users to opt out of `NonSecureTransport` policy requirement #7

Closed Scaldabagno closed 1 year ago

Scaldabagno commented 1 year ago

Description

Fix typo in conditions inside statement and remove the "NonSecureTransport" statement.

Motivation and Context

Without this change, the statement is created with no conditions.

Breaking Changes

NonSecureTransport statement not added by default, I would suggest to control it through a condition

How Has This Been Tested?

[x] I have tested in my infrastructure.

bryantbiggs commented 1 year ago

looks good to me - @antonbabenko

antonbabenko commented 1 year ago

This PR is included in version 1.1.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.