terraform-aws-modules / terraform-aws-eks

Terraform module to create Amazon Elastic Kubernetes (EKS) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/eks/aws
Apache License 2.0
4.48k stars 4.09k forks source link

17.10.0 Introduced a Breaking Change. #1570

Closed kevinmstephens closed 3 years ago

kevinmstephens commented 3 years ago

Description

We saw builds breaking 2 hours ago and I found this change that I think caused it and the timing matches up.

Terraform v1.0.3
on linux_amd64
Initializing plugins and modules...
╷
│ Error: Unsupported block type
│ 
│   on .terraform/modules/eks_cluster.eks/modules/node_groups/node_groups.tf line 72, in resource "aws_eks_node_group" "workers":
│   72:   dynamic "update_config" {
│ 
│ Blocks of type "update_config" are not expected here.
╵
Operation failed: failed running terraform plan (exit 1)

⚠️ Note

Before you submit an issue, please perform the following first:

  1. Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
  2. Re-initialize the project root to pull down modules: terraform init
  3. Re-attempt your terraform plan or apply and check if the issue still persists

Versions

Reproduction

Steps to reproduce the behavior:

Code Snippet to Reproduce

Expected behavior

Actual behavior

Terminal Output Screenshot(s)

Additional context

bryantbiggs commented 3 years ago

Can you please provide some additional information to help troubleshoot where the issue is emanating from

Versions

- Terraform:

- Provider(s):

- Module:
antonbabenko commented 3 years ago

@kevinmstephens thanks for opening this issue!

My bad, I missed the point that update_config support was added in v3.56.0 of Terraform AWS provider which was released last week.

I will make another release to fix versions requirements now.

antonbabenko commented 3 years ago

@kevinmstephens Fixed in #1571. v17.11.0 has been just released. Please try it and open a new issue if there is anything wrong.

I apologize for the incomplete release in v17.10.0.

github-actions[bot] commented 2 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.