cant set the tag k8s.io/cluster-autoscaler/enabled

[sagivle]

I have issues

cant set the tag autoscaling_enabled = true tried workers_group_defaults = {"autoscaling_enabled" = "true"} also in worker_groups "autoscaling_enabled" , "true"

I'm submitting a...

• [x ] bug report
• [ ] feature request
• [x ] support request
• [ ] kudos, thank you, warm fuzzy

What is the current behavior?

k8s.io/cluster-autoscaler/disabled

If this is a bug, how to reproduce? Please include a code sample if relevvant.

module "eks" { source = "terraform-aws-modules/eks/aws" version = "1.7.0" cluster_name = "${var.deploy_name}-${var.region}" subnets = ["${var.subnets}"] tags = "${map("Environment", "test")}" write_kubeconfig = "true" vpc_id = "${var.vpc_id}" worker_groups = "${var.worker_groups}" workers_group_defaults = {"autoscaling_enabled" = "true"} }

also tried worker_groups = "${list( map("asg_desired_capacity", "${local.asg_desired_capacity_count}", "asg_max_size", "${local.asg_max_size_count}", "asg_min_size", "${local.asg_min_size_count}", "instance_type", "${local.asg_node_machine_type}", "name", "worker", "autoscaling_enabled" , "true"))}"

What's the expected behavior?

Are you able to fix this problem and submit a PR? Link here if you have already.

no

Environment details

AWS EKS

• Affected module version:
• OS:
• Terraform version: v0.11.8

  Any other relevant info

[max-rocket-internet]

Hi @sagivle

Could you paste your full code inside a markdown code block so it's easier to read? Like this:

```hcl
some TF code here
\```

(but without that slash)

[max-rocket-internet]

e.g. here's mine:

module "01_stg" {
  source                               = "git@github.com:terraform-aws-modules/terraform-aws-eks.git?ref=v1.7.0"
  cluster_name                         = "01-stg"
  subnets                              = ["${module.vpc1.private_subnets}"]
  vpc_id                               = "${module.vpc1.vpc_id}"
  worker_additional_security_group_ids = ["${module.bastion_vpc1.allow_ssh_from_bastion_sg_id}"]

  worker_groups = [
    {
      instance_type       = "m4.xlarge"
      key_name            = "rps-default"
      asg_max_size        = 40
      autoscaling_enabled = true
      additional_userdata = "${module.bastion_vpc1.bastion_user_data_users}"
      pre_userdata        = "mkdir -p /var/log/journal"
    },
  ]

}

[dpiddockcmp]

Old problem of passing the string "true" not matching == 1 in the module code.

Pass 1 or true, no quotes. Maybe boolean handling gets better in Terrraform 0.12 with HCL2

[sagivle]

thanks @max-rocket-internet

[github-actions[bot]]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.