Aws eks addon version result crashes with adot

miachm commented 3 months ago

Description

When I try to install adot:

  cluster_addons = {
    amazon-cloudwatch-observability = {
      most_recent   = true
   }
}

Terraform plan crashes:

│ Error: reading EKS Add-On version info (adot, 1.30): empty result │ │ with module.eks.data.aws_eks_addon_version.this["adot"], │ on .terraform/modules/eks/main.tf line 490, in data "aws_eks_addon_version" "this": │ 490: data "aws_eks_addon_version" "this" {

I did a research and it seems like the API call "describe-addon-versions" returns an empty list for the kubernetes cluster 1.30.

I think the program should be able to ignore this problem, or at the bare least, don't execute the datasource if you provide the addon version.

Versions

Module version [Required]: 20.14.0
Terraform version: 1.8
Provider version(s): v5.55.0

Reproduction Code [Required]

module "eks" {
  source                         = "terraform-aws-modules/eks/aws"
  version                        = "~> 20.14.0"
  cluster_name                   = "test"
  cluster_version                = "1.30"

  cluster_addons = {
    amazon-cloudwatch-observability = {
      most_recent   = true

    }
}
}

Steps to reproduce the behavior:

No Yes It fails in the terraform plan ## Expected behavior To install the addon like I can do in the UI.

bryantbiggs commented 3 months ago

ADOT currently does not support 1.30

miachm commented 3 months ago

@bryantbiggs I can install it from the AWS console.

bryantbiggs commented 3 months ago

ADOT currently does not support 1.30

bryantbiggs commented 3 months ago

closing since this is not related to the module - you will need for the ADOT addon to support 1.30

github-actions[bot] commented 2 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-eks