terraform-aws-modules / terraform-aws-eks

Terraform module to create Amazon Elastic Kubernetes (EKS) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/eks/aws
Apache License 2.0
4.41k stars 4.05k forks source link

bootstrap_self_managed_addons forces recreate of EKS clusters. #3148

Closed afischer-opentext-com closed 3 weeks ago

afischer-opentext-com commented 3 weeks ago

Description

The issue https://github.com/terraform-aws-modules/terraform-aws-eks/issues/3143 and related pull request https://github.com/terraform-aws-modules/terraform-aws-eks/pull/3099 (introduced via provider version 5.58.0 causes a severe incompatibility which we fail to address.

Before the new flag got introduced the EKS cluster was implicitely created with bootstrapping addons. Now when keeping the default value (bootstrap_self_managed_addons is set to true per default), a recreate of the EKS cluster is forced. When configuring the value bootstrap_self_managed_addons to false, we end up with an EKS cluster without the addons.

Both is imho wrong, this is a breaking change and does not allow us to move forward.

Request: Consider to implement logic which does not force a recreation of existing clusters while not breaking their functionality.

Versions

Steps to reproduce the behavior:

Expected behavior

The cluster is not recreated while maintaining its functionality.

Actual behavior

The cluster is attempted to be recreated. Flipping configuration value to false causes degraded functionality as pieces such as coredns are no more available as before.

afischer-opentext-com commented 3 weeks ago

Closing, wrong project, sorry.