terraform-aws-modules / terraform-aws-eks

Terraform module to create Amazon Elastic Kubernetes (EKS) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/eks/aws
Apache License 2.0
4.41k stars 4.05k forks source link

Support AZRebalance for ASG when using eks_managed_node_groups #3149

Closed commodity729 closed 2 weeks ago

commodity729 commented 3 weeks ago

Is your request related to a problem? Please describe.

AZRebalance is not available when using eks_managed_node_groups

Describe the solution you'd like.

Support AZRebalance for ASG when using eks_managed_node_groups

Describe alternatives you've considered.

Manually enable this for ASG

Additional context

Not really sure the reason behind it, but I don't see anything related in module code when it comes to control suspended processes. In my case I need AZRebalance to be specifically disabled, so because your module does not support it, I had to enable this manually.

bryantbiggs commented 3 weeks ago

Does EKS managed node groups support this?

commodity729 commented 3 weeks ago

It is supported by asg, why it cannot be supported by terraform module?

bryantbiggs commented 3 weeks ago

That doesn't answer my question

bryantbiggs commented 2 weeks ago

closing for now - once this functionality is supported by EKS managed node groups then we can support it here as well