terraform-aws-modules / terraform-aws-elasticache

Terraform module to create AWS ElastiCache resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/elasticache/aws
Apache License 2.0
17 stars 28 forks source link

fix: Argument `replication_group_id` conflicts with `engine` and `log_delivery_configuration` #10

Closed magreenbaum closed 3 months ago

magreenbaum commented 4 months ago

Description

replication_group_id conflicts with engine. log_delivery_configuration in aws_elasticache_cluster should not be set if replication_group_id is set since cluster is being added to a replication group which can have its own log_delivery_configuration. Produces error like InvalidParameterCombination: Cannot specify additional cache cluster parameters when creating a replica cluster.

Motivation and Context

Related to:

https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/Replication.CreatingReplGroup.ExistingCluster.html https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/elasticache_cluster#redis-cluster-mode-disabled-read-replica-instance https://github.com/hashicorp/terraform-provider-aws/blob/0452bb53c686a9ac565febcc6d0ce02da18a0d8d/internal/service/elasticache/cluster.go#L143 https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/elasticache_cluster#engine

Breaking Changes

No.

How Has This Been Tested?

antonbabenko commented 3 months ago

This PR is included in version 1.2.2 :tada:

github-actions[bot] commented 2 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.