search

terraform-aws-modules / terraform-aws-elasticache

Terraform module to create AWS ElastiCache resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/elasticache/aws
Apache License 2.0
16 stars 28 forks source link

fix: Fix cache_usage_limits issue when empty map (default value) is provided. #13

Closed dszlawski-chaos closed 2 months ago

dszlawski-chaos commented 2 months ago

There is a bug in terraform provider which causes issues when deploying empty cache_usage_limits block (described here: https://github.com/hashicorp/terraform-provider-aws/issues/36374), passing empty map in var.cache_usage_limits as [var.cache_usage_limits] generates list with one element [ null, ] which causes terraform to pass empty cache_usage_limits hence triggers provider bug.

Description

Passing empty map in var.cache_usage_limits as [var.cache_usage_limits] generates list with one element [ null, ] which causes terraform to pass empty cache_usage_limits

Motivation and Context

There is a bug in terraform provider which causes issues when deploying empty cache_usage_limits block (described here: https://github.com/hashicorp/terraform-provider-aws/issues/36374), passing empty map in var.cache_usage_limits as [var.cache_usage_limits] generates list with one element [ null, ] which causes terraform to pass empty cache_usage_limits hence triggers provider bug.

Breaking Changes

None.

How Has This Been Tested?

Applied changes with updated module code.

antonbabenko commented 2 months ago

This PR is included in version 1.2.3 :tada:

github-actions[bot] commented 1 month ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.