terraform-aws-modules / terraform-aws-elasticache

Terraform module to create AWS ElastiCache resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/elasticache/aws
Apache License 2.0
17 stars 28 forks source link

fix: Change cloudwatch log group output to include all created log groups #19

Open ottramst opened 1 month ago

ottramst commented 1 month ago

Description

Change the Cloudwatch log group outputs to include all created log groups information

Motivation and Context

When using a configuration such as:

module "elasticache" {
  ...
    log_delivery_configuration = {
    engine-log = {
      destination_type                       = "cloudwatch-logs"
      log_format                             = "json"
      cloudwatch_log_group_retention_in_days = 7
      cloudwatch_log_group_kms_key_id        = module.kms_elasticache_logs.key_arn
    }
  }
  ...
}

the outputs of cloudwatch_log_group_name and cloudwatch_log_group_arn were null

Breaking Changes

None.

How Has This Been Tested?

ottramst commented 1 month ago

Can I get a pair of eyes on this please?

bryantbiggs commented 1 month ago

this is a breaking change - and one we should probably make at some point. however, why is this needed right now?

github-actions[bot] commented 4 days ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

ottramst commented 12 hours ago

I think it's needed because right now there is no way to get information from the module about operations regarding the Cloudwatch log groups.

If using the configuration provided in the initial message of the pull request, the specified outputs are null