terraform-aws-modules / terraform-aws-elasticache

Terraform module to create AWS ElastiCache resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/elasticache/aws
Apache License 2.0
16 stars 28 forks source link

feat: LogGroup #24

Closed AnkithaBH closed 3 weeks ago

AnkithaBH commented 3 weeks ago

Description

Currently, the module enforces cloud watch log group for Redis. Added a variable named "create_cloudwatch_log_group" to provide flexibility of choice to the end user, to leverage or not to leverage via this module.

Motivation and Context

Why is this change required? What problem does it solve? Enhances flexibility and effective internal usage.

How Has This Been Tested?

Could not use the existing examples as we have our own way of deriving networking information and for other reasons. Created own/separate example which is not included in the code. Tested the example code by enabling and disabling "create_cloudwatch_log_group" variable. Both are working without any issues. pre-commit run -a is executed successfully before creating PR.

bryantbiggs commented 3 weeks ago

Why is this change required? What problem does it solve? Enhances flexibility and effective internal usage.

That doesn't explain anything