terraform-aws-modules / terraform-aws-emr

Terraform module to create AWS EMR resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/emr/aws
Apache License 2.0
23 stars 22 forks source link

ebs_config could not take effect #19

Closed wbb1975 closed 7 months ago

wbb1975 commented 7 months ago

Description

If you specifiy ebs_config in core_instance_fleet section, it will be ignore when running "terraform plan", for example: core_instance_fleet = { name = "core fleet" target_on_demand_capacity = 10

instance_type_configs = [
  {
    bid_price_as_percentage_of_on_demand_price = 100
    ebs_config = 
      {
        size                 = 256
        iops                 = 4000
        type                 = "gp3"
        volumes_per_instance = 4
      }
    instance_type     = "r6a.2xlarge"
    weighted_capacity = 1
  }
]
launch_specifications = {
  on_demand_specification = {
    allocation_strategy = "lowest-price"
  }
}

} will output:

terraform plan will output: core_instance_fleet {

Versions

Your version of Terraform is out of date! The latest version is 1.7.5. You can update by downloading from https://www.terraform.io/downloads.html

Your version of Terraform is out of date! The latest version is 1.7.5. You can update by downloading from https://www.terraform.io/downloads.html

Reproduction Code [Required]

Please refer to above terarform snippet.

Steps to reproduce the behavior:

I use S3 as the backend. terraform init -backend-config=backend.config terraform plan terraform apply

Expected behavior

EC2 in setup EMR CLuster has EBS storage of 256 GB other than 64 GB.

Actual behavior

EC2 in setup EMR CLuster has EBS storage of 64 GB.

AkshayDubey29 commented 7 months ago

We are also facing the same issue, it seems.

bryantbiggs commented 7 months ago

I've opened a PR to update the examples to show the correct syntax - however, please checkout the note https://github.com/terraform-aws-modules/terraform-aws-emr/pull/20#issue-2225791964 - I would suggest opening a ticket on the upstream AWS provider to have this fixed there

antonbabenko commented 7 months ago

This issue has been resolved in version 2.0.0 :tada:

wbb1975 commented 7 months ago

Thank you @antonbabenko

github-actions[bot] commented 5 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.