feat: Add support for Amazon CloudWatch Observability IRSA role

terraform-aws-modules / terraform-aws-iam

Terraform module to create AWS IAM resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/iam/aws

Apache License 2.0

787 stars 996 forks source link

feat: Add support for Amazon CloudWatch Observability IRSA role #446

Closed JoeNorth closed 10 months ago

JoeNorth commented 10 months ago

Description

feat: Add support for Amazon CloudWatch Observability IRSA role

Motivation and Context

Adding support for creating IRSA role for Amazon CloudWatch Observability add-on

Breaking Changes

N/A

How Has This Been Tested?

[X] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[X] I have executed pre-commit run -a on my pull request

JoeNorth commented 10 months ago

Currently running into an issue in testing these changes. Attempting to deploy example/am-role-for-service-accounts-eks results in the following error:

│ Error: Invalid template interpolation value
│ 
│   on ../../modules/iam-role-for-service-accounts-eks/main.tf line 10, in locals:
│   10:   role_name_condition = var.role_name != null ? var.role_name : "${var.role_name_prefix}*"
│     ├────────────────
│     │ var.role_name_prefix is null
│ 
│ The expression result is null. Cannot include a null value in a string template.

This issue is also present in the master branch. @bryantbiggs thoughts?

antonbabenko commented 10 months ago

This PR is included in version 5.33.0 :tada:

github-actions[bot] commented 9 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.