feat: Add default description for role

terraform-aws-modules / terraform-aws-iam

Terraform module to create AWS IAM resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/iam/aws

Apache License 2.0

787 stars 996 forks source link

feat: Add default description for role #453

Closed AndrewCharlesHay closed 9 months ago

AndrewCharlesHay commented 9 months ago

Description

Creates a default role description for the oidc provider

Motivation and Context

Creates more clarity and traceability for IAM roles by default

Breaking Changes

None

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[X] I have executed pre-commit run -a on my pull request

bryantbiggs commented 9 months ago

thank you but this is not valid - we can't have a default description that is only applicable to one of the scenarios supported by this sub-module

AndrewCharlesHay commented 9 months ago

thank you but this is not valid - we can't have a default description that is only applicable to one of the scenarios supported by this sub-module

oh whoops you're right. I didn't think about the fact that it's used for other scenarios. Would it be ok if it checked attach_external_dns_policy and other similar variables or no?

bryantbiggs commented 9 months ago

what problem are you trying to solve?

AndrewCharlesHay commented 9 months ago

what problem are you trying to solve?

Just provide a good default role description. I'm fine if you'd prefer not to have the check

github-actions[bot] commented 8 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.