feat: add default role description

terraform-aws-modules / terraform-aws-iam

Terraform module to create AWS IAM resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/iam/aws

Apache License 2.0

787 stars 996 forks source link

feat: add default role description #454

Closed AndrewCharlesHay closed 9 months ago

AndrewCharlesHay commented 9 months ago

Description

Checks the attach_*_policy variable to add a fitting description for the role. Improvement on #453

Motivation and Context

Add a useful default description for the IAM role added

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[X] I have executed pre-commit run -a on my pull request

bryantbiggs commented 9 months ago

thank you, but we are not going to make this type of change. users are free to provide a description of their choosing

github-actions[bot] commented 8 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.