search

terraform-aws-modules / terraform-aws-iam

Terraform module to create AWS IAM resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/iam/aws
Apache License 2.0
779 stars 985 forks source link

feat: Add support for Mountpoint S3 CSI driver to EKS IRSA #459

Closed josmo closed 6 months ago

josmo commented 6 months ago

Description

Adding the required policy for the S3 CSI driver

Motivation and Context

Fixes https://github.com/terraform-aws-modules/terraform-aws-iam/issues/456

Breaking Changes

No breaking changes - simply addition for the policy required for the S3 CSI

How Has This Been Tested?

josmo commented 6 months ago

Thanks a ton for the comments @bryantbiggs I think I have everything working and I also did validate with the working config I have before these updates (and temp move blocks for the resources that there were no plan changes) let me know if I need to change anything else.

bryantbiggs commented 6 months ago

@antonbabenko - FYI, I had to add a hack into the pre-commit workflow since it looks like the Terraform bits are getting big and filling up disk. I wonder if this is related to the AWS SDK Go v1 to v2 migration - https://github.com/terraform-aws-modules/terraform-aws-iam/actions/runs/8126685348/job/22210719103?pr=459

image
antonbabenko commented 6 months ago

This PR is included in version 5.36.0 :tada:

antonbabenko commented 6 months ago

@antonbabenko - FYI, I had to add a hack into the pre-commit workflow since it looks like the Terraform bits are getting big and filling up disk. I wonder if this is related to the AWS SDK Go v1 to v2 migration - terraform-aws-modules/terraform-aws-iam/actions/runs/8126685348/job/22210719103?pr=459

Thanks for finding the solution to this problem. I thought it was related to many runs of "terraform init", but it is very good to have more space and delete stuff (another way to get more space - https://github.com/k8sgpt-ai/k8sgpt/pull/947 :) ).

github-actions[bot] commented 5 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.