feat: Enable override policy name iam-group-with-assumable-roles-policy

[schollii]

Description

Add an extra variable so that the assume-roles policy created by iam-group-with-assumable-roles-policy module can be customized with minimal effort: just have an optional suffix that defaults to empty so this PR is fully backwards compatible. Eg

module "iam_group_with_assumable_roles_policy_production_admin" {
  source = "../../modules/iam-group-with-assumable-roles-policy"

  name = "production-admin"
  assumable_roles = [module.iam_assumable_roles_in_prod.admin_iam_role_arn]
  assumable_roles_policy_name_suffix = "-assumable-roles"
  ...

Motivation and Context

I have been using this module for many months and I really dislike the default name, which is just the group name, because I for one have IAM groups that have a policies named after them since they represenent the group's "main permissions". Eg if I create group Foo, I have policy named Foo that gives that group it's basic set of permissions (eg read-only permissions), and I want a policy FooAssumeRoles that provides the roles that can be assumed by members of that group.

Breaking Changes

None

How Has This Been Tested?

• [x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
• [x] I have tested and validated these changes using one or more of the provided examples/* projects
• [x] I have executed pre-commit run -a on my pull request

I applied using the example, in my own AWS account, on master branch. Then I switched to my branch and re-planned: no changes. Then, I set a non-empty value to assumable_roles_policy_name_suffix and the diff was correct: policy would be replaced due to new name and the attachment too.

[bryantbiggs]

@Smana is there a reason you are outputting these statements across a number of our repositories? You've just displayed several details that most would not want to be publicly available

[Smana]

I'm confused, I'm currently testing the tofu-controller branch planner and I probably misconfigured something. I'm gonna delete these comments, sorry for the inconvenience.

[Smana]

That should be done by now. I'm gonna talk to the maintainers because honestly I don't know what I did wrong here. Let me know if I missed something.

[schollii]

@bryantbiggs I am not able to see why the "collect workflow inputs" pre-commit check fails, no logs for that action except "internal error"

[antonbabenko]

@schollii I rerun GH Actions, and now it shows that something is not right - https://github.com/terraform-aws-modules/terraform-aws-iam/actions/runs/8318806399/job/23343434805?pr=468

[schollii]

Yeah the collect workflow passes now. Not sure why all these additional files got changed, it's when I ran the pre-commit tool locally I think. Also I forgot to restore the example file so it will run on your aws, I needed to test in my own account. I'll clean all this up, sorry for the messy PR.

[schollii]

OK @antonbabenko the PR contains only the 4 files I intended to change and there is 1 wrapper file which I'm not sure should be changed but all pre-commit checks pass now

[oliver-sentianse]

Thanks for quick merge, I'll be making use of it today!

[antonbabenko]

This PR is included in version 5.39.0 :tada:

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.