search

terraform-aws-modules / terraform-aws-iam

Terraform module to create AWS IAM resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/iam/aws
Apache License 2.0
779 stars 985 forks source link

Remove excess SQS permissions #473

Closed scotthesterberg closed 5 months ago

scotthesterberg commented 5 months ago

This permission is no longer required per karpenter documentation: https://github.com/aws/karpenter-provider-aws/blob/v0.35.2/website/content/en/docs/reference/cloudformation.md?plain=1#L345-L354

Description

Removed a single line providing excess permissions for Karpenter per Karpenter documentation: https://github.com/aws/karpenter-provider-aws/blob/v0.35.2/website/content/en/docs/reference/cloudformation.md?plain=1#L345-L354

Motivation and Context

Came across this difference when setting up Karpenter SQS based spot interruption monitoring

Breaking Changes

Removing this line brings the code in line with the official Karpenter documentation. Removing it does not have any negative effects on functionality when tested on my Karpenter deployment.

How Has This Been Tested?

Removing this line does not have any negative effects on functionality when tested on my Karpenter deployment

bryantbiggs commented 5 months ago

just because its no longer required on later versions of Karpenter, I don't think we can safely drop this yet https://github.com/aws/karpenter-provider-aws/blob/234a43a9a67317773d86c0e62dfe2d233c251abe/website/content/en/docs/getting-started/getting-started-with-karpenter/cloudformation.yaml#L181

github-actions[bot] commented 4 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.