fix: Performs plan-phase runtime check only if building package

lorengordon commented 1 year ago

pip_requirements_step and npm_requirements_step are executed even when there is no requirements file, and so there is no package to build. The runtime check should occur only when the package is being built.

Motivation and Context

See https://github.com/terraform-aws-modules/terraform-aws-lambda/pull/358#issuecomment-1285685758

Breaking Changes

The opposite! It fixes a breaking change.

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

antonbabenko commented 1 year ago

This PR is included in version 4.1.3 :tada:

lorengordon commented 1 year ago

@guyzyl Are you able to confirm that the current master branch or v4.1.3 fix the error you reported in #358?

guyzyl commented 1 year ago

@lorengordon works perfectly now 👍

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-lambda