terraform-aws-modules / terraform-aws-lambda

Terraform module, which takes care of a lot of AWS Lambda/serverless tasks (build dependencies, packages, updates, deployments) in countless combinations 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws
Apache License 2.0
892 stars 662 forks source link

fix: Qualifiers in event invoke config #368

Closed sindrig closed 1 year ago

sindrig commented 1 year ago

Description

create_current_version_async_event_config and create_unqualified_alias_async_event_config were not working due to zipmap returning a map with qualifier as key and null as value if variables were set to false

Motivation and Context

there's currently no way to opt out of either current_version or unqualified_version for async event config

How Has This Been Tested?

I deployed the examples/alias example and modified the variables before my change, resulting in no change in terraform state. Then I applied my change and ran apply, and terraform wanted to remove the resources, as it should.

antonbabenko commented 1 year ago

This PR is included in version 4.2.1 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.