fix: Fixed opposite refresh_alias behavior in modules/alias

micksatana commented 1 year ago

Description

ignore_changes = [function_version] lifecycle should be in the no_refresh resource. This PR will solve #281

Fixes #281

Motivation and Context

Its behavior is currently opposite. refresh_alias = true should refresh new version to the alias.

Breaking Changes

If anyone uses opposite refresh_alias = false as a workaround to refresh version, one needs to update to true and vice versa.

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
- Note: existing Python example, not working in case a developer use pyenv so I update to Node.js example instead
- provisioned_concurrent_executions in the example was 1 after run the second apply it will failed not allowed to be lower than 10. This is unrelated to alias example. So removed from the example.
[x] I have tested and validated these changes using one or more of the provided examples/* projects
- terraform init, plan then apply
- Update ../fixtures/nodejs14.x-app1/index.js
- terraform apply
[x] I have executed pre-commit run -a on my pull request

antonbabenko commented 1 year ago

This PR is included in version 4.7.1 :tada:

ryandeivert commented 1 year ago

hi all -- while I greatly appreciate this fix (it's confused me for a long time), I'm concern that it has semi-silently landed in a patch fix. IMO, this is a breaking change, and even using the least egregious upgrade pattern (~> syntax) here would even adopted this breaking change.

I'm curious if there is a way to limit releasing breaking changes to (at a minimum) the minor version releases, even when it is a known-bug fix. unfortunately, this caused numerous functions to unexpectedly stop publishing, and I bet it is also affecting many many others without them noticing 😞

jguttman94 commented 1 year ago

agreed! I suspect that this issue (https://github.com/terraform-aws-modules/terraform-aws-lambda/issues/383) is a result of this change.

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-lambda