feat: Add max session duration for IAM role

terraform-aws-modules / terraform-aws-lambda

Terraform module, which takes care of a lot of AWS Lambda/serverless tasks (build dependencies, packages, updates, deployments) in countless combinations 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws

Apache License 2.0

886 stars 657 forks source link

feat: Add max session duration for IAM role #391

Closed sindrig closed 1 year ago

sindrig commented 1 year ago

Description

Add ability to specify maximum session duration for the created role.

Motivation and Context

We're using this module to create all our services. In development, the developers assume the roles of the services to mimic the permissions they have. By default the sessions can have a maximum duration of an hour (3600 seconds) and that means that developers need to re-assume multiple times per day.

Breaking Changes

There should be no changes as the default remains the same.

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

github-actions[bot] commented 1 year ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

sindrig commented 1 year ago

@antonbabenko any chance of getting a review on this?

github-actions[bot] commented 1 year ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

sindrig commented 1 year ago

Still relevant

github-actions[bot] commented 1 year ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

sindrig commented 1 year ago

@antonbabenko any chance on getting this merged?

antonbabenko commented 1 year ago

Please fix the CI by pinning the version of the VPC module to version ~> 3.0

sindrig commented 1 year ago

Please fix the CI by pinning the version of the VPC module to version ~> 3.0

Done!

antonbabenko commented 1 year ago

This PR is included in version 4.14.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.