search

terraform-aws-modules / terraform-aws-lambda

Terraform module, which takes care of a lot of AWS Lambda/serverless tasks (build dependencies, packages, updates, deployments) in countless combinations 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws
Apache License 2.0
886 stars 657 forks source link

Add ability to set consumer group names for Amazon Managed and Self Managed Kafka cluster #397

Closed wilkejo closed 1 year ago

wilkejo commented 1 year ago

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

resource/aws_lambda_event_source_mapping: Add amazon_managed_kafka_event_source_config and self_managed_kafka_event_source_config configuration blocks

Is your request related to a problem? Please describe.

The configuration blocks self_managed_kafka_event_source_config or amazon_managed_kafka_event_source_config are not considered by the module. Therefore it isn't possible to define the consumer group name. This is necessary as in our Kafka setup, the ACLs only allow specific consumer group names for specific user

Describe the solution you'd like.

add the both new blocks as additional dynamic (?) blocks on the same level as dynamic "self_managed_event_source"

Describe alternatives you've considered.

Couldn't find and alternative to setup the consumer group name

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

wilkejo commented 1 year ago

not stale. MR is still open

Nunalves commented 1 year ago

What's blocking this issue from being merged? Really need this feature also.

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.