feat: Add dynamic blocks for consumer group id config

terraform-aws-modules / terraform-aws-lambda

Terraform module, which takes care of a lot of AWS Lambda/serverless tasks (build dependencies, packages, updates, deployments) in countless combinations 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws

Apache License 2.0

886 stars 657 forks source link

feat: Add dynamic blocks for consumer group id config #399

Closed wilkejo closed 1 year ago

wilkejo commented 1 year ago

Description

Add two more dynamic blocks within the lambda trigger config to allow defining kafka consumer group ids

Motivation and Context

Fixes https://github.com/terraform-aws-modules/terraform-aws-lambda/issues/397

Breaking Changes

This isn't a breaking change

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

wilkejo commented 1 year ago

I tested the changes within my setup and extended the example.

github-actions[bot] commented 1 year ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

Nunalves commented 1 year ago

Shouldn't be stale. Should be merged. This feature is needed.

antonbabenko commented 1 year ago

This PR is included in version 4.11.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.