feat: Update docker provider pin to 2.x in docker-build submodule

terraform-aws-modules / terraform-aws-lambda

Terraform module, which takes care of a lot of AWS Lambda/serverless tasks (build dependencies, packages, updates, deployments) in countless combinations 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws

Apache License 2.0

886 stars 657 forks source link

feat: Update docker provider pin to 2.x in docker-build submodule #401

Closed mbeacom closed 1 year ago

mbeacom commented 1 year ago

Description

The goal of this PR is to resolve docker provider deprecation issues resulting from the docker provider transition to 3.x. This major update to the provider removes interface compatibility between docker_image and docker_remote_image.

Resolves: #398

Motivation and Context

Ensure the module works out of the box, until the module can be updated to use the latest variant of the docker provider implementation.

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

antonbabenko commented 1 year ago

Thanks, @mbeacom !

antonbabenko commented 1 year ago

This PR is included in version 4.8.0 :tada:

mbeacom commented 1 year ago

Thanks for the quick merge!

mbeacom commented 1 year ago

@antonbabenko Just wanted to give you a heads up... Something may have failed in the release job. It appears the registry hasn't received 4.8.0 yet.

antonbabenko commented 1 year ago

Thanks for the heads up! I just hit the Registry magic button to resync this module.

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.