search

terraform-aws-modules / terraform-aws-lambda

Terraform module, which takes care of a lot of AWS Lambda/serverless tasks (build dependencies, packages, updates, deployments) in countless combinations 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws
Apache License 2.0
886 stars 657 forks source link

Support for replace_security_groups_on_destroy and replacement_security_group_ids #418

Closed ricoli closed 1 year ago

ricoli commented 1 year ago

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

Is your request related to a problem? Please describe.

Yes - destroying VPC associated lambdas taking a long time because of waiting for the security group(s) to no longer be used by the ENIs. See https://github.com/hashicorp/terraform-provider-aws/issues/10329#issuecomment-1425914496 for details

Describe the solution you'd like.

Support for the newly introduced replace_security_groups_on_destroy and replacement_security_group_ids lambda function arguments

Describe alternatives you've considered.

Additional context

antonbabenko commented 1 year ago

Good idea! PR is welcome.

ricoli commented 1 year ago

Good idea! PR is welcome.

Sure, here you go: https://github.com/terraform-aws-modules/terraform-aws-lambda/pull/422

ricoli commented 1 year ago

Good idea! PR is welcome.

Sure, here you go: #422

@antonbabenko any chance my PR could get a review please?

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.