fix: Pass docker object to docker_run_command to fix #427

terraform-aws-modules / terraform-aws-lambda

Terraform module, which takes care of a lot of AWS Lambda/serverless tasks (build dependencies, packages, updates, deployments) in countless combinations 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws

Apache License 2.0

886 stars 656 forks source link

fix: Pass docker object to docker_run_command to fix #427 #443

Closed pdecat closed 1 year ago

pdecat commented 1 year ago

Resolves #427

Root issue is that docker_additional_options was added by https://github.com/terraform-aws-modules/terraform-aws-lambda/pull/366 after I started working on adding poetry support in #311, and it was merged before, and I missed it during rebasing.

antonbabenko commented 1 year ago

This PR is included in version 4.13.0 :tada:

pdecat commented 1 year ago

Thanks @antonbabenko!

Somehow, this does not appear in the release notes: https://github.com/terraform-aws-modules/terraform-aws-lambda/releases/tag/v4.13.0

antonbabenko commented 1 year ago

I guess it was because the PR title wasn't valid when I merged it (while driving, probably, hehe). The title didn't have fix: ... at the beginning, so it was not included in the release notes.

I have updated the release notes manually now.

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.