search

terraform-aws-modules / terraform-aws-lambda

Terraform module, which takes care of a lot of AWS Lambda/serverless tasks (build dependencies, packages, updates, deployments) in countless combinations 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws
Apache License 2.0
886 stars 656 forks source link

Add support for java17 to validation check #463

Closed mrf closed 1 year ago

mrf commented 1 year ago

Description

AWS now supports java17 runtime https://aws.amazon.com/about-aws/whats-new/2023/04/aws-lambda-java-17/

Motivation and Context

Currently failing validation despite java17 being available

Breaking Changes

None

How Has This Been Tested?

None

antonbabenko commented 1 year ago

There is no need in this validation (it is already commented out).

mrf commented 1 year ago

Where does this error come from? Error: expected runtime to be one of [nodejs nodejs4.3 nodejs6.10 nodejs8.10 nodejs10.x nodejs12.x nodejs14.x nodejs16.x java8 java8.al2 java11 python2.7 python3.6 python3.7 python3.8 python3.9 dotnetcore1.0 dotnetcore2.0 dotnetcore2.1 dotnetcore3.1 dotnet6 nodejs4.3-edge go1.x ruby2.5 ruby2.7 provided provided.al2 nodejs18.x], got java17 Was this only commented out recently?

antonbabenko commented 1 year ago

Run terraform init -upgrade and make sure that you're using Terraform AWS provider v4.66.0 or newer where support for java17 was introduced.

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.