feat: Make `compatible_runtimes` optional, added sam metadata control

ajschmidt8 commented 11 months ago

Description

This PR makes the compatible_runtimes argument for the aws_lambda_layer_version resource optional.

Motivation and Context

Currently, the compatible_runtimes value is inferred from var.compatible_runtimes and var.runtime.

If neither of these values is set, the module throws an error.

I'm trying to use this module to publish a Lambda layer that doesn't depend on any particular runtime (it's just a plain-text configuration file).

Therefore, I'd expect that I'd be able to publish this layer without having to specify a runtime.

The official aws_lambda_layer_version resource docs mention that this argument is optional (see here), so I'd expect that it would be optional in this module as well.

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

ajschmidt8 commented 10 months ago

@antonbabenko, can you take a look at this when you have a moment?

github-actions[bot] commented 9 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

ajschmidt8 commented 9 months ago

this is not stale.

@antonbabenko, can you check on this PR soon?

github-actions[bot] commented 8 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

ajschmidt8 commented 8 months ago

@antonbabenko, can you check on this PR?

It addresses a legitimate bug.

antonbabenko commented 8 months ago

This PR is included in version 6.2.0 :tada:

github-actions[bot] commented 7 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-lambda