search

terraform-aws-modules / terraform-aws-lambda

Terraform module, which takes care of a lot of AWS Lambda/serverless tasks (build dependencies, packages, updates, deployments) in countless combinations 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws
Apache License 2.0
886 stars 656 forks source link

fix: Fixed npm install on Windows without having to use wsl #502

Closed eicki closed 9 months ago

eicki commented 9 months ago

Description

Use of npm.cmd on WINDOWS instead of npm within install_npm_requirements method

Motivation and Context

https://github.com/terraform-aws-modules/terraform-aws-lambda/issues/414 describes the issue, it has been closed with the resolution that WSL should be used. While this is a solution not all development teams use WSL. Additionally, the package.py already contains specific WINDOWS handling anyway (e.g. for python).

Fixes https://github.com/terraform-aws-modules/terraform-aws-lambda/issues/414

Breaking Changes

no breaking change imho

How Has This Been Tested?

locally on my Windows machine.

antonbabenko commented 9 months ago

This PR is included in version 6.0.1 :tada:

github-actions[bot] commented 8 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.