feat: Added variable to control the create log group permission

jake-naughton commented 7 months ago

Description

Adding a variable to control the create log group permission on the lambda role. Default for the new variable is to add the permission to the role.

Motivation and Context

Described in the following feature request: Fixes https://github.com/terraform-aws-modules/terraform-aws-lambda/issues/503

Breaking Changes

None, variable default will keep current behaviour the same.

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

Tested running the example/complete module with init, plan, apply, destroy and inspected the iam roles to confirm that existing lambda roles still had the create log group permission and the new lambda role does not have it.

antonbabenko commented 7 months ago

This PR is included in version 6.5.0 :tada:

github-actions[bot] commented 6 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-lambda