docs: Update docs to clarify create_role and lambda_role usage

terraform-aws-modules / terraform-aws-lambda

Terraform module, which takes care of a lot of AWS Lambda/serverless tasks (build dependencies, packages, updates, deployments) in countless combinations 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws

Apache License 2.0

886 stars 656 forks source link

docs: Update docs to clarify create_role and lambda_role usage #527

Closed victortrac closed 5 months ago

victortrac commented 5 months ago

Description

Adds clarification to the README and variables.tf about create_role and lambda_role.

Motivation and Context

The lack of this information in the docs made troubleshooting this module take some time.

Breaking Changes

None.

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[ ] I have executed pre-commit run -a on my pull request

antonbabenko commented 5 months ago

Such an addition to the explanation is not necessary because if we change the logic of the module (rarely we do it) we need to remember to update the description of the variable. Instead, we should provide good feature coverage with examples.

github-actions[bot] commented 4 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.