fix: Dynamic logging config for Gov Cloud

terraform-aws-modules / terraform-aws-lambda

Terraform module, which takes care of a lot of AWS Lambda/serverless tasks (build dependencies, packages, updates, deployments) in countless combinations 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws

Apache License 2.0

885 stars 658 forks source link

fix: Dynamic logging config for Gov Cloud #541

Closed AndrewCharlesHay closed 5 months ago

AndrewCharlesHay commented 5 months ago

Description

Make the logging configuration only an object on the aws partition

Motivation and Context

See #539

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[ ] I have executed pre-commit run -a on my pull request

AndrewCharlesHay commented 5 months ago

I haven't added tests yet but I will tomorrow. I'd still love a pair of eyes if someone gets a chance 👀

AndrewCharlesHay commented 5 months ago

I should have mentioned but there is an issue stating the same problem for China See https://github.com/hashicorp/terraform-provider-aws/issues/34809

AndrewCharlesHay commented 5 months ago

Here is the official AWS documentation mentioning that it is only commercial cloud

🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦

antonbabenko commented 5 months ago

This PR is included in version 7.2.1 :tada:

github-actions[bot] commented 4 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.