terraform-aws-modules / terraform-aws-lambda

Terraform module, which takes care of a lot of AWS Lambda/serverless tasks (build dependencies, packages, updates, deployments) in countless combinations 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws
Apache License 2.0
885 stars 658 forks source link

Add documentation covering setup for DIND (docker in docker) packaging #544

Closed david-heward-unmind closed 1 month ago

david-heward-unmind commented 4 months ago

Is your request related to a new offering from AWS?

No

Is your request related to a problem? Please describe.

When running the terraform module in a DIND (docker in docker) setup there are additional setup requirements. It would be good to document them.

Describe the solution you'd like.

I would like docs to be expanded to cover a working solution for DIND since most folk will be simply mounting /var/run/docker.sock into the container, the commands to mount source code simply will not work as the expectation will be that the source code locations exist on the host and not container. It may also be somewhat responsible for other reported issues with missing files.

I am about to fix this for a setup. Will add some additional context and maybe even a fix as soon as I have it.

Describe alternatives you've considered.

N/a

Additional context

n/a

CMorton737 commented 3 months ago

@david-heward-unmind Were you able to make any progress here? I've run into this issue myself and any guidance would be appreciated

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

david-heward-unmind commented 2 months ago

@david-heward-unmind Were you able to make any progress here? I've run into this issue myself and any guidance would be appreciated

@CMorton737 I did fix this. I'll try to dig up how for you.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 1 month ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 2 weeks ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.