search

terraform-aws-modules / terraform-aws-lambda

Terraform module, which takes care of a lot of AWS Lambda/serverless tasks (build dependencies, packages, updates, deployments) in countless combinations 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws
Apache License 2.0
885 stars 658 forks source link

fix: Fixed constant drift with Lambda logging configuration #551

Closed antonbabenko closed 3 months ago

antonbabenko commented 3 months ago

A simple configuration like this was marking version, qualified_arn and qualified_invoke_arn as (known after apply):

  logging_log_format = "JSON"

The user used to pass some extra arguments to reduce noise:

  logging_log_group             = "/aws/lambda/adapting-tadpole-test"
  logging_application_log_level = "DEBUG"
  logging_system_log_level      = "INFO"

This PR sets defaults for log level to avoid such behavior.

Ideally, this should be fixed in Terraform AWS provider. Related issues: https://github.com/hashicorp/terraform-provider-aws/issues/33383 https://github.com/hashicorp/terraform-provider-aws/issues/33955

antonbabenko commented 3 months ago

This PR is included in version 7.2.3 :tada:

github-actions[bot] commented 2 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.