fix: AttributeError os.exists is not valid python attribute.

terraform-aws-modules / terraform-aws-lambda

Terraform module, which takes care of a lot of AWS Lambda/serverless tasks (build dependencies, packages, updates, deployments) in countless combinations 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws

Apache License 2.0

885 stars 658 forks source link

fix: AttributeError os.exists is not valid python attribute. #554

Closed lociko closed 3 months ago

lociko commented 3 months ago

Description

Fixed an attribute error made by typo

Motivation and Context

This is an error - should be fixed

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[ ] I have executed pre-commit run -a on my pull request

code-intensive commented 3 months ago

Several of my CI/CD pipelines have failed as a result of this typo. The one-liner should be resolved as soon as possible.

pdecat commented 3 months ago

Several of my CI/CD pipelines have failed as a result of this typo. The one-liner should be resolved as soon as possible.

Sorry, I did not notice this issue before as we pin module versions (and then let renovatebot perform the upgrades).

pdecat commented 3 months ago

Please update the PR title so checks can pass.

lociko commented 3 months ago

Please update the PR title so checks can pass.

Done

pdecat commented 3 months ago

Hi @antonbabenko, can you merge this? 🙏

pdecat commented 3 months ago

@antonbabenko Too bad, semantic release did not understand the commit message:

[2:02:10 PM] [semantic-release] › ℹ  Start step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[2:02:10 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analyzing commit: Fix AttributeError os.exists is not valid python attribute. (#554)
[2:02:10 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  The commit should not trigger a release
[2:02:10 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analysis of 1 commits complete: no release
[2:02:10 PM] [semantic-release] › ✔  Completed step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[2:02:10 PM] [semantic-release] › ℹ  There are no relevant changes, so no new version is released.

https://github.com/terraform-aws-modules/terraform-aws-lambda/actions/runs/8481753919/job/23239717584

antonbabenko commented 3 months ago

@pdecat could you please make a small PR with any change and good PR title. I will merge it asap. I am traveling/flying and can't do it myself quickly.

michal-organek commented 3 months ago

I guess commit should have semantic commit convention format fix: AttributeError os.exists is not valid python attribute. instead of Fix AttributeError os.exists is not valid python attribute..

One option is to merge PR using squash with PR summary as commit name. Second option - add one more PR check like GitHub - wagoid/commitlint-github-action: Lints Pull Request commits with commitlint.

pdecat commented 3 months ago

@antonbabenko Here we go https://github.com/terraform-aws-modules/terraform-aws-lambda/pull/555

antonbabenko commented 3 months ago

This PR is included in version 7.2.5 :tada:

github-actions[bot] commented 2 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.