terraform-aws-modules / terraform-aws-lambda

Terraform module, which takes care of a lot of AWS Lambda/serverless tasks (build dependencies, packages, updates, deployments) in countless combinations 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws
Apache License 2.0
885 stars 658 forks source link

feat: Added support for alias to have multiple filter criteria same as function #585

Closed aleboarna closed 1 week ago

aleboarna commented 1 week ago

… event source mappings, same as lambda function

Description

I have added support in the alias submodule to have multiple event source mapping filter_criteria in line with the main lambda function.

Motivation and Context

I have wasted an entire evening trying to make event source mapping filter_criteria work on the alias with

operation error Lambda: CreateEventSourceMapping, https response error StatusCode: 400, RequestID: 4d25b930-c830-49e2-bbc7-dbd4add503f7, InvalidParameterValueException: Invalid filter pattern definition.

This is based on the example found here

Breaking Changes

Alias will be in line with the existing documentation.

How Has This Been Tested?

aleboarna commented 1 week ago

Hi @pdecat @antonbabenko,

Could you please review/approve this PR to fix the alias event mapping issue and align it with existing documentation please ?

antonbabenko commented 1 week ago

This PR is included in version 7.7.0 :tada:

aleboarna commented 1 week ago

thank you very much! :D