Closed carldjohnston closed 11 months ago
thank you, I'll take a deeper look in a bit. we'll need to bump the minimum version of the AWS provider throughout the project to 5.12 https://github.com/terraform-aws-modules/terraform-aws-msk-kafka-cluster/blob/eaab9e18a8d951d0a5d208947c77f01a3c2ad26d/versions.tf#L7
Thanks @bryantbiggs I've pushed a commit to bump the provider version to >= 5.12.0
This PR is included in version 2.2.0 :tada:
Thanks for accepting my contribution @bryantbiggs :)
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Description
This change adds support for adding "Multi-VPC" connections to a cluster.
https://docs.aws.amazon.com/msk/latest/developerguide/aws-access-mult-vpc.html
Motivation and Context
This adds support for enabling multi-vpc connections for a cluster, and creating aws_msk_vpc_connection to a VPC which was released in version 5.12.0 of the aws provider.
Breaking Changes
I don't believe there are any breaking changes introduced by this change, however enabling multi-vpc requires that the cluster be already running instances larger than
kafka.t3.small
. I was unable to enable multi-vpc and scale up the instance size in the same operation.How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull requestThis was tested by modifying the
examples/complete
module. The cluster was first upgraded tokafka.m5.large
in one operation, then multi-vpc was enabled in another operation.