Closed aidanmelen closed 1 year ago
What's more this change is NONE BREAKING for existing deployments that are using the deprecated broker_node_ebs_volume_size.ebs_volume_size
.
The resulting plan after switching to the new broker_node_ebs_volume_size.ebs_volume_size
results in the expected addition of the and setting provisioned_throughput.enable = false
e.g.
~ storage_info {
~ ebs_strage_info {
# (1 unchanged attribute hidden)
+ provisioned_throughput {
+ enabled = false
}
}
# (1 unchanged block hidden)
}
@bryantbiggs is there anything else you would like me to test?
@bryantbiggs any plans to merge this PR?
Hi @bryantbiggs, client_unauthenticated_access_enabled is a handy feature for sandbox cluster. Can this PR be merged? Happy to give a hand if needed.
Any chance this will get merged?
yes, apologies - I will carve out some time to review and make some additional changes and get this moved over to https://github.com/terraform-aws-modules
apologies for the delay ... life and stuff π€·π½ββοΈ ... but we're pushing the updates now and then moving it over to terraform-aws-modules
where it will live out the rest of its days. The current versions on the registry under clowdhaus
will stay indefinitely so no need to upgrade until you are ready
:tada: This issue has been resolved in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
I'm going to lock this pull request because it has been closed for 30 days β³. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Description
Add support for the MSK
storage_info
block. This includes the new provisioned volume throughput feature.Using the new
storage_info
block did require setting the minimum version for the aws provider to be>= 4.15.0
. Here are the release notes for the aws provider.Add support for unauthenticated TLS connections. Added new variable
client_unauthenticated_access_enabled
with a default value set tofalse
for backwards comparability.Motivation and Context
This PR fixes this issue: #3
How Has This Been Tested?
The basic example runs without any modifications. The
broker_node_ebs_volume_size
variable now gets passed to thebroker_node_ebs_volume_size.storage_info.ebs_storage_info.volume_size
resource block rather than the deprecatedbroker_node_ebs_volume_size.ebs_volume_size
argument.I also update the complete example to have volume throughput configured. Running a plan showed that the module variables were correctly passed the
storage_info
the MSK resource e.g.Screenshots (if appropriate):