search

terraform-aws-modules / terraform-aws-notify-slack

Terraform module to create AWS resources for sending notifications to Slack 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/notify-slack/aws
Apache License 2.0
470 stars 343 forks source link

Any way to upgrade lambda module version to relax the AWS provider version requirement for TF 0.12? #102

Closed anarsen closed 4 years ago

anarsen commented 4 years ago

Note This issue might belong in terraform-aws-modules/terraform-aws-lambda - sorry if that's the case

Context

The latest version for TF 0.12 as of this writing is v3.4.0, and relies on https://github.com/terraform-aws-modules/terraform-aws-lambda/tree/v1.6.0.

Unfortunately, terraform-aws-modules/terraform-aws-lambda v1.6.0 has a pretty strict version requirement on the aws provider:

https://github.com/terraform-aws-modules/terraform-aws-lambda/blob/aea2b6da21bcde99ed5fdd0ccc27378b84eeda25/versions.tf#L5

Question

What are your thoughts on creating a Terraform 0.12-compatible version of terraform-aws-modules/terraform-aws-lambda with a more relaxed AWS provider version pin such as aws = ">= 2.46".

antonbabenko commented 4 years ago

Good point. I think we can have Lambda module version 1.6.0 updated to have support for AWS provider version 3, which is going to be used just by this notify-slack module.

antonbabenko commented 4 years ago

v3.5.0 has been just released with this improvement.

anarsen commented 4 years ago

Thanks for the swift response, @antonbabenko. It works as expected.

github-actions[bot] commented 2 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.