search

terraform-aws-modules / terraform-aws-opensearch

Terraform module to create AWS OpenSearch resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/opensearch/aws
Apache License 2.0
18 stars 25 forks source link

docs(vpc_options): Improve description for public access #17

Closed dim-ops closed 4 months ago

dim-ops commented 4 months ago

Description

It took me a while to realise that I had to leave the vpc_options variable = {} to deploy a public opensearch. I propose to provide a little more explanation

Motivation and Context

Making the creation of a public opensearch more explicit

Breaking Changes

None

How Has This Been Tested?

I ran pre-commit

bryantbiggs commented 4 months ago

thank you but I don't think that is appropriate here. this description is taken directly from the provider docs https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/opensearch_domain#vpc_options - we expose the configuration in the modules, but the variable descriptions are not intended to teach users how to configure the service to their use case

dim-ops commented 4 months ago

thank you but I don't think that is appropriate here. this description is taken directly from the provider docs https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/opensearch_domain#vpc_options - we expose the configuration in the modules, but the variable descriptions are not intended to teach users how to configure the service to their use case

On the serverless module there is at least example with AllowFromPublic.... As you wish

github-actions[bot] commented 3 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.