search

terraform-aws-modules / terraform-aws-opensearch

Terraform module to create AWS OpenSearch resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/opensearch/aws
Apache License 2.0
15 stars 22 forks source link

fix: Wrong conditional for master_user_options #5

Closed strangeman closed 5 months ago

strangeman commented 5 months ago

Description

Found an error in master_user_options conditional creation

Old behavior (master_user_name = try(master_user_options.value.master_user_name, null) == null ? try(master_user_options.value.master_user_name, null) : null):

if master_user_options.value.master_user_name == null
then
    try to put master_user_options.value.master_user_name (which is null due to the previous statement)
else (if master_user_options.value.master_user_name is not null)
   put null

Should be:

if master_user_options.value.master_user_name != null
then
    try to put master_user_options.value.master_user_name (which is not null due to the previous statement)
else (if master_user_options.value.master_user_name is null)
   put null
antonbabenko commented 5 months ago

This issue has been resolved in version 1.1.1 :tada:

github-actions[bot] commented 4 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.