search

terraform-aws-modules / terraform-aws-rds-aurora

Terraform module to create AWS RDS Aurora resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/rds-aurora/aws
Apache License 2.0
384 stars 565 forks source link

Support setting `preferred_maintenance_window` on Serverless V1 clusters #395

Closed stagha closed 1 year ago

stagha commented 1 year ago

Is your request related to a new offering from AWS?

Yes. It is not clear if the provider needs updating at all. From my cursory look at the provider code, it simply passes the parameters to AWS and lets AWS deal with it.

Is your request related to a problem? Please describe.

AWS added support for configuring maintenance windows on Serverless V1 clusters in February, as described in this announcement. The terraform-aws-rds-aurora module does not pass the preferred_maintenance_window argument down to the aws_rds_cluster resource if engine_mode is serverless.

Describe the solution you'd like.

It looks like all it takes is a one-line change to remove the conditional here. However, I admit I have not tested the resource directly to verify it works.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 1 year ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 12 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

antonbabenko commented 7 months ago

This issue has been resolved in version 9.0.1 :tada: