fix: Allow Serverless maintenance windows

ricardo-mng commented 8 months ago

Description

AWS added support for configuring maintenance windows on Serverless V1 clusters in February 2023, as described in this announcement. The terraform-aws-rds-aurora module does not pass the preferred_maintenance_window argument down to the aws_rds_cluster resource if engine_mode is serverless.

This change was done in the context of this issue 213

Note: Also tested to set the preferred_backup_window attribute on serverless, but it still gives the error: InvalidParameterCombination: You currently can't modify BackupWindow with Aurora Serverless

Motivation and Context

We cannot warn our customers of database maintenance that has downtime because of this limitation.

Resolves #395

Breaking Changes

There are no breaking changes.

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes against several internal existing implementations.
[x] I have executed pre-commit run -a on my pull request

antonbabenko commented 7 months ago

This PR is included in version 9.0.1 :tada:

github-actions[bot] commented 6 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-rds-aurora